docs(kermt): fix install and Dockerfile paths in the vendored KERMT README#6
Open
evasnow1992 wants to merge 2 commits into
Open
docs(kermt): fix install and Dockerfile paths in the vendored KERMT README#6evasnow1992 wants to merge 2 commits into
evasnow1992 wants to merge 2 commits into
Conversation
Bring the KERMT open-model skill bundle up to date with the KERMT repo main branch (NVIDIA-BioNeMo/KERMT @ 85f255f): - Adds the released-model download path: scripts/fetch_released_model.py + config/released_model.json, and the --pretrained-release / default-to- nvidia/NV-KERMT-70M-v2 flow in the finetune / embed / continue-pretrain SKILL.md files. - Refreshes all 8 SKILL.md, all runner/validator scripts, and the unit tests. - Regenerates the installable plugin SKILL.md copies. - Updates .skillsource.json (resolved_sha + files list). - Preserves the toolkit's Apache-2.0 OR CC-BY-4.0 dual-license identifier on all synced files (SPDX headers + SKILL.md frontmatter); KERMT ships Apache-2.0 only. - Keeps the toolkit metadata convention: drops KERMT's owner: frontmatter field (no personal owner email in the public repo). .skillsource.json was hand-updated (the autogenerate sync tool is not in the public repo); a future generator run should reproduce it. Signed-off-by: Eva Xue <evax@nvidia.com>
Mirror of the upstream KERMT agent/README.md fix. The vendored copy drops the `agent/` prefix during vendoring, which left install snippets pointing at a non-existent `agent/skills/` and a dangling `../Dockerfile` link. Use README-relative `skills/` paths and reference `$KERMT_REPO/Dockerfile` (the image the skills actually build from), so the instructions work from this bundle. Test-helper invocations qualified with `$KERMT_REPO/`. Stopgap until the README is re-vendored from KERMT source by the autogenerate build step. Signed-off-by: Eva Xue <evax@nvidia.com>
Collaborator
Author
|
This PR currently includes the changes in #3 . That PR will need to be merged first before this one can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two path references in the vendored KERMT skills README (
open-models-skills/kermt/README.md) did not resolve in this repo's layout:agent/skills/kermt-*/, which does not exist here — following it installs no skills.../Dockerfile"at the repo root", which does not resolve in this repo, so the image-build reference dangles.Root cause: this README is vendored from the KERMT model repo's
agent/directory (recorded in.skillsource.json), and vendoring relocates the files without theagent/prefix. Paths written relative to the KERMT repo roottherefore no longer resolve once the file lands at
open-models-skills/kermt/README.md.Changes
agent/skills/...->skills/..., expressed relative to the README's own directory (matching the file's otherskills/links) so they resolve both in the KERMT repo and in this vendored copy.../Dockerfilelink with$KERMT_REPO/Dockerfile— the pathkermt-setupactually builds the image from. No broken link, correct in either location.$KERMT_REPO/. The innerpytest agent/tests/...paths are intentionally left repo-relativeRelationship to the KERMT source
These are open-model skills whose canonical source is the KERMT model repo (
agent/). The equivalent fix is being made upstream inagent/README.mdusing layout-independent paths (README-relative for install references,$KERMT_REPO/...for repo-root references), so re-syncing the vendored copy from source preserves it. No repo-specific path hardcoding was introduced here, to keep this copy aligned with the upstream README.